aminghadersohi commented on PR #44603: URL: https://github.com/apache/superset/pull/44603#issuecomment-5998432435
Addressed both follow-ups in cde8d98a464efe8c3a5b86d411918acf935fe4d7: - Saved-metric hints use metric slots, not the presence of an aggregate. Regression tests cover aggregated x/group_by dimensions, y with/without aggregate, and aggregate/raw table columns. - Column candidates preserve dataset-owned spelling with a per-name length bound, matching context and metric hints. Tests cover quotes, ampersands, filtering-like names, singular/plural errors, and candidate bounds. Validation: 214 targeted tests passed; pre-commit passed on all branch-changed files (including mypy, Ruff, and pylint). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
