villebro commented on issue #44875: URL: https://github.com/apache/superset/issues/44875#issuecomment-5999347751
Thanks @msyavuz ! Comments below > 1. Can the Canvas SIP add fields to WidgetBehavior and WidgetUi, or would you rather list them in here? I need to have some fields for canvas to read related to layout: (grid_columns, accepted_children etc.) Yes, good callout. TBH I have mostly focused on the general viz-like widget, and I don't have much context on the layout etc functionality, so I will probably need help defining those 👍 > 3. A runtime filter can only narrow data, so it can't express "group by region instead of country". How should a dynamic group by reach a chart's query? It's a feature that not many use but we might still want to not block it. Dynamic group bys are a bit of a security concern, and nullify some of the security guarantees the new charting contract introduces. I'm all for supporting these types of advanced "filters", but we will need to introduce security safeguards that make it possible to limit access to this feature. For now I'd propose starting with just additive filters, and expanding later. > 4. Can a complete, valid instance be written in one step without a draft? Or would that break anything the draft path protects? As commented on Michael's feedback, I'm not currently heavily opinionated on this topic, and I'm open to changing this aspect of the proposal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
