KristiDodaj opened a new pull request, #44990: URL: https://github.com/apache/superset/pull/44990
### SUMMARY Replace direct property and array index access with destructuring across frontend code and tests to clear existing `prefer-destructuring` violations. The rule remains set to `warn`. A follow-up PR will promote it to `error` and remove its TODO comment after this cleanup merges and CI passes. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A. Code refactoring with no intended UI changes. ### TESTING INSTRUCTIONS 1. From `superset-frontend`, run `npm run lint`. 2. Temporarily change `prefer-destructuring` to `error` in `oxlint.json`, rerun lint, then restore it to `warn`. 3. Run `npm run plugins:build` followed by `npm run type`. 4. Run `npm run test`. Validated with Oxlint 1.82.0 on an isolated snapshot matching the local changes. Full frontend lint checked 3,981 files with zero errors at temporary `error` severity. A rule-only audit also found zero violations, including normally ignored Cypress files. Formatting checks passed. An isolated run passed 27 existing tests. Full project tests and type checking still require CI verification because dependency loading stalls in the local checkout. The standard pre-commit run passed formatting, whitespace, end-of-file and large-file checks, then was stopped after the Oxlint hook stalled. The complete pre-commit suite has not passed locally. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
