aminghadersohi commented on code in PR #44893:
URL: https://github.com/apache/superset/pull/44893#discussion_r4187295356
##########
docs/admin_docs/configuration/mcp-server.mdx:
##########
@@ -1658,3 +1666,18 @@ predicate, whose behavior varied by database. It is not
an indexed
full-text search: large catalogs and long descriptions can increase scan time.
Benchmark with your metadata database and catalog size when tuning discovery
latency.
+
+### Managing and applying dashboard native filters
+
+`manage_native_filters` requires a numeric dataset column when adding a
+`filter_range` filter or changing its dataset/column target. Select filters
+continue to accept nonnumeric columns.
+
+For `apply_dashboard_filters`, pass `time_grain` as a list containing at most
+one datasource-supported duration (for example, `["P1D"]`). Custom engine
+durations are accepted when exposed in the datasource's time-grain options,
+rather than limited to a fixed enum.
+A nonempty `time_grains` list in the saved filter configuration restricts the
+allowed selection and takes precedence over dataset options; missing or empty
Review Comment:
Fixed in 077de9a4e6ca7cb7a661cbd6f43b33a2f769b1a4. Both documentation
passages state that a selected time grain must be supported by the target
dataset and, when nonempty, the configured allowlist. Dashboard tests: 802
passed; pre-commit, including mypy, passed.
##########
superset/mcp_service/dashboard/schemas.py:
##########
@@ -2489,33 +2553,78 @@ class ApplyFilterValueSpec(BaseModel):
"'No filter' to clear the filter."
),
)
+ range: List[int | float | None] | None = Field(
Review Comment:
Fixed in 077de9a4e6ca7cb7a661cbd6f43b33a2f769b1a4. Each range bound has a
before-validator rejecting booleans before integer coercion. Schema and tool
regression tests cover true and false in either bound and verify no permalink
is created. Dashboard tests: 802 passed; pre-commit, including mypy, passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
