AmoghAtreya commented on code in PR #44957: URL: https://github.com/apache/superset/pull/44957#discussion_r4187316124
########## superset-frontend/src/explore/components/controls/ZoomConfigControl/ZoomConfigControl.test.tsx: ########## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { render, screen, userEvent } from 'spec/helpers/testing-library'; +import ZoomConfigControl from './ZoomConfigControl'; +import { ZoomConfigs } from './types'; + +jest.mock('./ZoomConfigsChart', () => () => null); + +test.each([ + { + field: 'width' as const, + sliderIndex: 0, + value: { + type: 'FIXED', + configs: { zoom: 5, width: 100, height: 100 }, + values: {}, + } satisfies ZoomConfigs, + }, + { + field: 'height' as const, + sliderIndex: 1, + value: { + type: 'FIXED', + configs: { zoom: 5, width: 100, height: 100 }, + values: {}, + } satisfies ZoomConfigs, + }, + { + field: 'slope' as const, + sliderIndex: 2, + value: { + type: 'LINEAR', + configs: { zoom: 5, width: 100, height: 100, slope: 2 }, + values: {}, + } satisfies ZoomConfigs, + }, + { + field: 'exponent' as const, + sliderIndex: 3, + value: { + type: 'EXP', + configs: { zoom: 5, width: 100, height: 100, exponent: 1 }, + values: {}, + } satisfies ZoomConfigs, + }, +])( + 'copies configs for $field without mutating the incoming value', + async ({ field, sliderIndex, value }) => { + const onChange = jest.fn(); + const originalFieldValue = value.configs[field]; + Object.freeze(value.configs); + + render( + <ZoomConfigControl + name="zoomConfig" + label="Zoom configuration" + onChange={onChange} + value={value} + />, + ); + + const slider = screen.getAllByRole('slider')[sliderIndex]; + await userEvent.click(slider); + await userEvent.type(slider, '{arrowright}'); + + expect(value.configs[field]).toBe(originalFieldValue); + const updatedValue = onChange.mock.lastCall?.[0] as ZoomConfigs; + expect(updatedValue.configs).not.toBe(value.configs); Review Comment: Just resolved this mistake. I didn't take the suggestion from Copilot but instead solved it in another manner. I didn't apply the suggested changeset because `expect(updatedValue.configs[field]).not.toBe(originalFieldValue)` already failed in CI on this PR. The `{arrowright}` interaction on Ant Design sliders does not reliably change the value in GitHub Actions, so that assertion can pass locally and fail in CI (or pass without actually proving the field changed). I kept the intent of the comment: - assert `onChange` is called - assert the original `configs` object is not mutated - assert `onChange` receives a new `configs` reference - assert `configs[field]` is the expected next value - locate each control by name instead of `getAllByRole('slider')[index]` The test now mocks `ControlFormItem` and invokes `onAfterChange` with a known value, so the field-update assertion is deterministic and not coupled to slider keyboard behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
