aminghadersohi commented on PR #43771: URL: https://github.com/apache/superset/pull/43771#issuecomment-6002332705
Commit c0c84e1e66b4624ac6ec9767adc28c1a7caed70c closes both P3 findings from review 5420035652: - HAVING hint dead end (discussion_r4188365138): unsupported SIMPLE HAVING filters no longer suggest saved metrics. Existing WHERE behavior is preserved, and the regression test fails before the fix and passes afterward. - Sunburst secondary_metric hint (discussion_r4188365145): secondary_metric receives the same saved-metric near-miss guidance as the primary metric, without changing other chart types. Both sunburst metric slots are covered by a regression test. Validation: tests/unit_tests/mcp_service/chart plus test_tool_inventory.py — 3979 passed, 3 skipped. pre-commit run --files on all four touched files passed after formatting fixes (including mypy). Documentation updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
