bito-code-review[bot] commented on code in PR #44938:
URL: https://github.com/apache/superset/pull/44938#discussion_r4188669387
##########
pyproject.toml:
##########
@@ -109,7 +109,7 @@ dependencies = [
"sshtunnel>=0.4.0, <0.5",
"simplejson>=4.1.2",
"slack_sdk>=3.44.0, <4",
- "sqlalchemy>=2.0.52, <2.1",
+ "sqlalchemy>=2.1.1, <2.2",
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Dependency version conflict</b></div>
<div id="fix">
This pin (`sqlalchemy>=2.1.1,<2.2`) conflicts with
`superset-core/pyproject.toml:48` which still declares
`sqlalchemy>=2.0.0,<2.1`. Since `apache-superset-core` is a hard dependency
(pyproject.toml:38, editable via `[tool.uv.sources]`), the resolver must
satisfy both ranges, which are disjoint — `uv sync`/`pip install -e .` will
fail to resolve. Bump superset-core's pin in the same change or keep `<2.1`.
</div>
</div>
<small><i>Code Review Run #ea4a32</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
