bito-code-review[bot] commented on PR #44992: URL: https://github.com/apache/superset/pull/44992#issuecomment-6003343641
<!-- Bito Reply --> The issue is valid. When `report_format` is set to `NONE`, the `requires_attachment()` method returns `False`, causing the validation logic to bypass dashboard resolution and access checks, which leads to the test failures. To resolve this, the test assertions should be updated to account for this early return path when `report_format` is `NONE`. I have checked the available context and there are no other comments on this PR to address. Would you like me to implement the fix for this test case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
