aminghadersohi commented on PR #44560: URL: https://github.com/apache/superset/pull/44560#issuecomment-6007963487
@gabotorresruiz thanks for the thorough review. I fixed all four points in https://github.com/apache/superset/commit/896996e4bc90312b71082241125c4eafb236bbb4: - Charts attached from Explore but not yet in the layout no longer block the tool. The layout is still checked for structure, and every chart node that was there before the edit must still be there after it. - Externally managed dashboards are refused. - Header text is stored exactly as typed. It only gets trimmed, has invisible characters removed, and is capped in length. - Markdown height has a lower bound of `GRID_MIN_ROW_UNITS` (5). The 10 new tests fail on 04daf098 and pass on this commit. `tests/unit_tests/mcp_service/dashboard` passes (881 tests), and pre-commit, including mypy, is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
