aminghadersohi commented on PR #43770: URL: https://github.com/apache/superset/pull/43770#issuecomment-6008037328
Fixed the required unit-test failure in ee6c82462fbe72509a2f5a8c6e69b7a4a330d5ed, after a normal merge of master in 572fce9efa. The isolated Decimal test passes on the original PR head (8626abb61f) and freshly fetched master (ce39d221aa), one test each. The failure reproduces after merging master: upstream 2fdf756cf1 (#44949) intentionally promotes the last SQL result to top-level rows and sets its per-statement data to null to avoid duplication. The PR-added assertion was stale against that contract. Updated only that assertion; the exact Decimal string/precision checks remain intact, and production code is unchanged. Validation on the new head: full tests/unit_tests/mcp_service suite: 8,160 passed, 4 skipped; focused SQL tool/response tests: 73 passed; staged-file pre-commit and pre-commit across all files in the PR diff: passed, including mypy and frontend type checking. No unresolved review threads. Pushed normally; fresh CI is pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
