aminghadersohi commented on PR #45021: URL: https://github.com/apache/superset/pull/45021#issuecomment-6019379543
Review findings addressed in e4454d3e54: - Finding 1: reject scope_chart_ids when updating a divider. Tests cover empty/nonempty scopes, no write command on rejection, and successful scope updates for regular filters. - Finding 3: exclude dividers from apply_dashboard_filters available-filter error lists. Tests cover mixed and divider-only dashboards. Documentation updated. - Finding 2: no code change in e4454d3e54; #44985 remains open and its merge is absent from freshly fetched origin/master. Coordination waits on #44985 merging. After it lands, merge origin/master without rebasing, keep _merge_select_default inside the non-divider branch, and re-measure the combined TOOL_BUDGETS entry by the existing convention. Validation: PYTHONPATH=superset-core/src pytest tests/unit_tests/mcp_service/dashboard tests/unit_tests/mcp_service/test_tool_inventory.py -q — 993 passed. Staged-file and branch-wide pre-commit checks passed, including mypy and Ruff; explicit Ruff check and git diff --check passed. No environment started. PR remains draft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
