rebenitez1802 commented on PR #43523: URL: https://github.com/apache/superset/pull/43523#issuecomment-6021881834
@sadpandajoe thanks for the thorough review — I've pushed fixes for both of your latest comments in `a4ad132` (and merged `master` to clear the conflict): - **Cross-scope image disclosure** (worker rebind): `compute_and_cache` now discards any retained image when it rebinds a cache entry to a *different* scope, so one object's bytes can never be served under another object's authorized `screenshot` URL during the COMPUTING/ERROR window. ([thread](https://github.com/apache/superset/pull/43523#discussion_r4198053172)) - **Image dropped on retry-rotation and enqueue failure**: the carry gate no longer requires an `UPDATED` predecessor (a still-valid `ERROR` generation carries its last-good bytes forward), and `mark_cache_error_if_incomplete` preserves a valid same-scope image instead of unconditionally discarding. ([thread](https://github.com/apache/superset/pull/43523#discussion_r4198053492)) Both follow one rule: retain a cached image only when it's valid **and** its scope matches the object being rendered; discard on any scope change. Added unit + integration tests for the cross-scope discard, the retry-rotation carry, and the `mark_cache_error_if_incomplete` retain/drop behavior. Ready for another review when you have a chance — thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
