codeant-ai-for-open-source[bot] commented on PR #44282:
URL: https://github.com/apache/superset/pull/44282#issuecomment-6025169008

   ## CodeAnt PR Risk: High Risk
   
   - The PR should not merge yet because the Trino SSL toggle can indicate 
HTTPS while the connection uses plain HTTP.
   - In adjust_engine_params, setdefault preserves an existing 
http_scheme="http" over protocol=https, and a new test explicitly locks in that 
behavior.
   
   **Assessed commit:** `56b441f73e16`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to