FrancescoCastaldi opened a new pull request, #45038:
URL: https://github.com/apache/superset/pull/45038

   ### SUMMARY
   Fixes #44983.
   
   When saving a dashboard as a copy with duplicated charts 
(duplicate_slices=True), chartsInScope and scope.excluded within native filters 
metadata continued to reference the old chart slice IDs, breaking filter scope 
bindings on the new dashboard.
   
   This change:
   1. Implements _remap_filter_scopes and _remap_filter_scope in DashboardDAO 
(superset/daos/dashboard.py).
   2. Remaps chart IDs in chartsInScope and scope.excluded across 
native_filter_configuration, global_chart_configuration, and 
chart_configuration using old_to_new_slice_ids.
   3. Handles dividers and non-dictionary elements gracefully without raising 
errors.
   
   ### TESTING INSTRUCTIONS
   Run the dashboard DAO unit tests:
   pytest tests/unit_tests/dao/dashboard_test.py
   
   All tests pass, confirming correct slice ID remapping for single and 
multi-filter dashboards.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: fixes #44983
   - [x] Changes UI: No
   - [x] Requires DB Migration: No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to