codeant-ai-for-open-source[bot] commented on code in PR #45041:
URL: https://github.com/apache/superset/pull/45041#discussion_r4203428296
##########
superset/db_engine_specs/duckdb.py:
##########
@@ -315,7 +315,7 @@ class DuckDBEngineSpec(DuckDBParametersMixin,
BaseEngineSpec):
@classmethod
def epoch_to_dttm(cls) -> str:
- return "datetime({col}, 'unixepoch')"
+ return "(TIMESTAMP 'epoch' + {col} * INTERVAL '1 second')"
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `41e6a2f`.
The epoch conversion now passes `{{col}}` to `to_seconds()` instead of
multiplying it by an interval, so addition and subtraction are evaluated within
the function argument.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
