codeant-ai-for-open-source[bot] commented on code in PR #45052:
URL: https://github.com/apache/superset/pull/45052#discussion_r4210468680
##########
superset-frontend/src/dashboard/actions/dashboardState.ts:
##########
@@ -937,7 +951,16 @@ export function addSliceToDashboard(
return Promise.all([
dispatch(addChart(newChart, id)),
- dispatch(fetchDatasourceMetadata(form_data.datasource as string)),
+ dispatch(
+ fetchDatasourceMetadata(
+ form_data.datasource as string,
+ (form_data.datasource as string).endsWith(
+ `__${DatasourceType.SemanticView}`,
+ )
+ ? getState().dashboardInfo.id
+ : undefined,
+ ),
+ ),
]).then(() => {
dispatch(addSlice(selectedSlice as Slice));
});
Review Comment:
**Suggestion:** When an uncached ordinary datasource fetch fails,
`Promise.all` rejects after `addChart` runs, skipping `addSlice` and leaving
the chart partially added.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Incomplete
implementation`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=990021ea36054f198248eb9d0f699976&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=990021ea36054f198248eb9d0f699976&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/dashboard/actions/dashboardState.ts
**Line:** 952:966
**Comment:**
*Incomplete Implementation: When an uncached ordinary datasource fetch
fails, `Promise.all` rejects after `addChart` runs, skipping `addSlice` and
leaving the chart partially added.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45052&comment_hash=7a357c0b69f50d8bc1e333af6b3e5d3beff68027db563b62c75bfb62b203638a&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45052&comment_hash=7a357c0b69f50d8bc1e333af6b3e5d3beff68027db563b62c75bfb62b203638a&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
