codeant-ai-for-open-source[bot] commented on code in PR #45033:
URL: https://github.com/apache/superset/pull/45033#discussion_r4210469331
##########
superset/versioning/unit_of_work.py:
##########
@@ -41,14 +61,61 @@ def process_before_flush(self, session: Session) -> None:
"""Decide before Continuum creates its transaction or version
session."""
if session is self.version_session or not
self._capture_enabled(session):
return
+ if self.version_session is None and self.is_modified(session):
+ self._ensure_version_session(session)
super().process_before_flush(session)
+ def _ensure_version_session(self, session: Session) -> None:
+ """Join caller-owned work and reattach surviving cached versions."""
+ if self.version_session is None:
+ # The application session owns savepoints. Continuum's default
+ # conditional_savepoint creates an extra savepoint that outlives
+ # its parent when the application rolls that parent back.
+ # rollback_only prevents auxiliary commit/close from ending caller
+ # work; an auxiliary rollback still rolls back the caller boundary,
+ # consistent with the application flush failing as well.
+ self.version_session = Session(
+ bind=session.connection(),
join_transaction_mode="rollback_only"
Review Comment:
**Suggestion:** When Continuum's auxiliary flush fails inside an application
savepoint, `rollback_only` propagates its rollback to the outer transaction,
discarding work outside that savepoint.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f5a3f906d7444844b3f8cb44370e2ffc&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f5a3f906d7444844b3f8cb44370e2ffc&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/versioning/unit_of_work.py
**Line:** 78:78
**Comment:**
*Api Mismatch: When Continuum's auxiliary flush fails inside an
application savepoint, `rollback_only` propagates its rollback to the outer
transaction, discarding work outside that savepoint.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45033&comment_hash=6551f099c6b74df2f2f895e80d30923a9c13f82b36a3f0a5c18a3922664357ce&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45033&comment_hash=6551f099c6b74df2f2f895e80d30923a9c13f82b36a3f0a5c18a3922664357ce&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
