mikebridge commented on code in PR #44832:
URL: https://github.com/apache/superset/pull/44832#discussion_r4211378550
##########
superset/exceptions.py:
##########
@@ -240,6 +240,31 @@ class QueryObjectValidationError(SupersetException):
status = 400
+class SemanticResultCompletenessError(QueryObjectValidationError):
Review Comment:
Good point, thanks. Providers now have a public error to raise:
`superset_core.semantic_layers.errors.SemanticResultCompletenessError(reason)`
([6a5250cff9](https://github.com/apache/superset/commit/6a5250cff94b6a6040abf6f822fb21edea57d83a),
renamed in
[5353297590](https://github.com/apache/superset/commit/5353297590d86b2ee0fc8792757943c030ac96a1)
/
[52578e49ec](https://github.com/apache/superset/commit/52578e49ecc97f14692c21440f1fdc5bdd8580b6)
so the name is accurate for both reasons, `"incomplete"` and `"unverified"`).
The host refers to it only through the core module and converts it to
`superset.exceptions.SemanticResultCompletenessError` at the provider-call
boundary (the mapper's main and offset dispatch, and every `values_for_column`
`get_values` call), so the two never shadow each other, and incomplete results
are never cached. The host error reuses the core reason alias, so the reason
set is defined once. The host error is still accepted from providers for one
release, and the contract page notes the public error is available from
`apache-superset-core` 0.2.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
