sadpandajoe opened a new pull request, #45066:
URL: https://github.com/apache/superset/pull/45066

   ### SUMMARY
   The "Filters out of scope" collapsible section in the dashboard filter bar's 
vertical panel used antd's default `Collapse` header/content padding, which is 
larger than the compact spacing the surrounding `FilterControls` sections use 
(`SectionHeader`/`SectionContent`/`StyledDivider`). Since this collapsible 
renders directly above the "Display controls" section, the extra bottom padding 
visibly pushed "Display controls" down.
   
   This trims the header and content-box bottom padding on that one `Collapse` 
instance to match the filter bar's existing spacing rhythm.
   
   ### BEFORE/AFTER SCREENSHOTS
   N/A — CSS-only spacing fix validated by reading the computed antd token 
values (ghost `Collapse` header/content padding) and comparing against the 
sibling `SectionContainer`/`SectionContent` spacing in the same file. I did not 
have a running Superset instance to capture screenshots.
   
   ### TESTING INSTRUCTIONS
   1. Open a dashboard with tabs and native filters where at least one filter 
is out of scope for the current tab.
   2. Open the vertical filter bar panel.
   3. Confirm the "Filters out of scope (N)" row no longer adds extra space 
before "Display controls" below it.
   
   Existing tests pass unchanged:
   - `FilterControls.test.tsx` (13 tests)
   - `FiltersDropdownContent.test.tsx` (3 tests)
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue
   - [ ] Required feature flags
   - [ ] Changes UI
   - [ ] Includes DB migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to