mikebridge commented on code in PR #44997:
URL: https://github.com/apache/superset/pull/44997#discussion_r4212093425
##########
superset/semantic_layers/models.py:
##########
@@ -591,6 +592,33 @@ def columns(self) -> list[ColumnMetadata]:
def column_names(self) -> list[str]:
return [dimension.name for dimension in self._unique_dimensions]
+ @property
+ def main_dttm_col(self) -> str | None:
Review Comment:
Good catch, this was a coverage gap.
[9168006](https://github.com/apache/superset/commit/9168006de7a455216040668e43d768384d621973)
adds a test that gives a semantic view `entity_time` first and the preferred
`metric_time`, then runs it through `_apply_granularity` with a bounded ad-hoc
axis. It checks that `metric_time` becomes the filter granularity without
changing the axis. The test passed against the existing production path, so
this follow-up adds coverage without changing behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
