aminghadersohi commented on code in PR #44851:
URL: https://github.com/apache/superset/pull/44851#discussion_r4214038035
##########
superset-frontend/src/features/semanticViews/SemanticViewEditModal.tsx:
##########
@@ -187,16 +220,104 @@ export default function SemanticViewEditModal({
},
});
addSuccessToast?.(t('Semantic view updated'));
- onSave();
- onHide();
+ if (isCurrent()) {
+ onSave();
Review Comment:
Closing the editor mid-Save with no sync now skips `onSave`, so DatasetList
shows the old description after the success toast; master refreshes it.
Skipping only when a sync completed after Save started keeps the race fix. No
suggestion: it needs a ref set in `handleSync` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
