sadpandajoe commented on code in PR #45044: URL: https://github.com/apache/superset/pull/45044#discussion_r4214921466
########## superset/translations/ja/LC_MESSAGES/messages.po: ########## @@ -5308,14 +5357,14 @@ msgstr "項目を削除" msgid "" "Delete or move active datasets. To remove archived datasets, open " "Recently archived and select Delete permanently." -msgstr "" +msgstr "アクティブなデータセットを削除または移動します。アーカイブされたデータセットを削除するには、「最近のアーカイブ」を開き、「完全に削除」を選択してください。" Review Comment: This tells users to open 「最近のアーカイブ」, but both "Recently Archived" and "Recently archived" are translated as plain アーカイブ in this PR (lines 11205 and 11208), so no menu entry or page title matches the instruction. Could the wording here and those two labels be aligned? ########## superset/translations/ja/LC_MESSAGES/messages.po: ########## @@ -3091,13 +3132,13 @@ msgid "Center" msgstr "中央" msgid "Center value" -msgstr "" +msgstr "中央値" Review Comment: "Center value" here is the pivot of the diverging color scale (the neighbouring messages compare it to the min/max bounds), but 中央値 is what this file uses for "median" (see `msgid "median"`). Someone formatting profit/loss around zero can read this as "enter the data median" and set the wrong pivot. Would 中心値 fit better here, and in the two "Center value should be …" messages below? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
