mikebridge commented on code in PR #45062:
URL: https://github.com/apache/superset/pull/45062#discussion_r4214934634
##########
superset/mcp_service/dashboard/tool/governance_utils.py:
##########
@@ -118,3 +116,14 @@ def find_and_authorize_dashboard(
def dashboard_url(dashboard: "Dashboard") -> str:
"""Build the user-facing dashboard URL, preferring slug over id."""
return f"{get_superset_base_url()}/dashboard/{dashboard.slug or
dashboard.id}/"
+
+
+def managed_dashboard_refusal(dashboard: "Dashboard") -> str | None:
+ """Return the shared refusal for an externally managed dashboard."""
+ if dashboard.is_managed_externally:
Review Comment:
Thanks for flagging the race. At this PR's merge-base, certification already
read `is_managed_externally` before its commit
(`manage_dashboard_certification.py:110,144`), as did markdown
(`manage_dashboard_markdown.py:353,474`); this PR moves those reads into
`governance_utils.py:123` without changing the check-to-commit interval.
Transaction-level protection for these tools is a separate follow-up, not a
change this PR makes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
