alexandrusoare opened a new pull request, #45090: URL: https://github.com/apache/superset/pull/45090
### SUMMARY A user with edit permission can drag and resize widgets on a canvas, and the layout persists. There's no edit mode — handles appear on hover on the canvas as it's viewed. A user without edit permission sees the same canvas with no handles. The server keeps owning placement: the client turns a pointer delta into whole grid units, clamps it to the grid and the widget's declared span limits, and sends one place op. The server resolves collisions as before and returns the resolved placements. The drop preview turns red while it covers a neighbour, matching the dashboard's drop-indicator--forbidden. Two additions to the definition response support this: canEdit, computed with raise_for_editorship so the UI hides exactly what the write path refuses, and layoutConstraints, the span limits a resize clamps to. Also fixes two hook gaps for canvases replacing dashboards: CreateCanvasCommand now fires AFTER_ASSET_CREATE (it was silently skipping canvases), and ExtraAccessQueryFilters declares the canvases key that CanvasAccessFilter already read. Only moving within a widget's own grid is included — dragging between containers (MoveOp) is not. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
