aminghadersohi commented on PR #45081:
URL: https://github.com/apache/superset/pull/45081#issuecomment-6062102144
Addressed in 61efcbdadd.
The proxy-level outcome and timing metrics are now skipped when `call_tool`
returns a failure rather than raising it, because the proxied tool already
counted that failure with its own warning/error classification. The result
still carries `isError`, and the call is still logged as unsuccessful.
Added tests covering a proxied validation failure and a proxied permission
failure (`isError` true, one counter, same as the direct call), direct failures
with and without the proxy installed, and proxied success (unchanged).
`get_chart_type_schema({})` through `call_tool` now increments only `.warning`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
