eschutho opened a new pull request, #45094:
URL: https://github.com/apache/superset/pull/45094
### SUMMARY
pyparsing 3.3 emits \`PyparsingDeprecationWarning\` for its camelCase API.
\`superset/utils/date_parser.py\` is the only pyparsing user in the repo and
still called \`parseString\`, \`setName\`, \`setParseAction\` and
\`quotedString\`. \`parseString\` in \`datetime_eval()\` fires on every
time-range parse that reaches it (\`get_since_until\`); the others fire once
per process when the cached \`datetime_parser()\` grammar is built.
This renames them to the snake_case equivalents (\`parse_string\`,
\`set_name\`, \`set_parse_action\`, \`quoted_string\`), available since
pyparsing 3.0. \`pyproject.toml\` already requires \`pyparsing>=3.3.2\`.
**No behavior change:** the camelCase names are thin wrappers over the
snake_case ones. One file, +13/-13, no logic touched.
**Decisions made that were not in the instructions:** None.
### TESTING INSTRUCTIONS
- \`pytest tests/unit_tests/utils/date_parser_tests.py\` (48 pass).
- Run \`datetime_eval('DATEADD(DATETIME("2020-01-01"), 1, day)')\` with
\`python -W error\`; no pyparsing warning is raised (on master it raises for
\`setName\`).
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
