Vitor-Avila commented on code in PR #44992:
URL: https://github.com/apache/superset/pull/44992#discussion_r4224336420
##########
superset/commands/report/execute.py:
##########
@@ -1542,7 +1597,8 @@ def _get_notification_content(self) ->
NotificationContent: # noqa: C901
)
if (
- self._report_schedule.chart
+ self._attachments_enabled()
Review Comment:
Called this out in `UPDATING.md` now. Expected change Skip attachments means
no data query, and just focus on the notification. Including the chart as a
text would still fire a chart query that could affect the notification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
