mikebridge commented on PR #45071: URL: https://github.com/apache/superset/pull/45071#issuecomment-6070416121
Thanks for spelling out the archived-asset case. We're keeping archived dependents non-blocking for source deletion; dashboard restore is tracked separately in SC-125586. To be precise about charts: #44925 landed after the head you reviewed, and this update merges it. It makes chart *version-history* restore refuse a version whose datasource no longer exists. Restoring an archived chart from Trash is a different path, and it still succeeds. With #44926, also merged here, the restored chart's datasource-derived permissions are cleared because its source is gone, so it fails closed rather than keeping stale access. It still comes back as a chart without a datasource, though. So this doesn't resolve your example end to end; making Trash restore refuse or warn is a follow-up, not part of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
