mikebridge commented on PR #45100: URL: https://github.com/apache/superset/pull/45100#issuecomment-6070831104
Pushed a small naming follow-up. `metadata_cache_token` meant two different things, so the host side is now called `metadata_generation`: - **Host (ORM) `SemanticLayer` / `SemanticView`:** `metadata_generation` is the database-scoped generation that keys host caches. Results, annotation sources, value suggestions and compatibility all read it, and it's what the provider factory receives as `cache_token`. - **SDK `SemanticView.metadata_cache_token`** and **`from_configuration_with_cache_token(cache_token=)`** are unchanged. The docstrings now say the view property is only the provider echoing back the token it was built with, and the host never keys on it. - **ORM `SemanticView.metadata_cache_token`** is a deprecated alias of `metadata_generation`. It stays only until the containment cache in #42760 reads the new name. No behavior or cache-key change: the generation string and the key payloads are byte-identical. The semantic-layer suite still meets the 100% coverage gate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
