mikebridge commented on PR #45060: URL: https://github.com/apache/superset/pull/45060#issuecomment-6074708051
Thanks for the careful equivalence review and mutation checks. Joe's SQL-dataset test concern is addressed in `af8bf960ef`: the test now counts query-context access decisions and fails if the semantic preflight also runs for SQL datasets. Your non-blocking points remain valid. A custom security manager can see the first `raise_for_access` call with `queries=[]`, and allowed semantic requests still pay for two decisions. The guest exclusion and semantic `GET /api/v1/chart/<pk>/data/` path would benefit from direct regression tests. This test-only commit does not change those behaviors; I have kept them visible as follow-up review items rather than claiming they are covered here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
