aminghadersohi commented on PR #45149: URL: https://github.com/apache/superset/pull/45149#issuecomment-6086712593
Review items addressed in 23b892033b96edeabc9c67c1ee2546e289786142: 1. (Medium) Closed in 23b892033b96edeabc9c67c1ee2546e289786142. Name coverage now requires the name's words as a contiguous, in-order run in the query. New negative tests: "create a dashboard from a dataset" does not promote create_dataset, and "list all the charts on a dashboard" does not promote list_charts. 2. (Low) Closed in 23b892033b96edeabc9c67c1ee2546e289786142. New test spells a hidden tool's full name inside a longer query under the read-only RBAC setup and asserts no denied tool is returned. 3. (Nit) Closed in 23b892033b96edeabc9c67c1ee2546e289786142. The BM25 _search docstring now covers contiguous name-run promotion. 4. (Nit) Closed in 23b892033b96edeabc9c67c1ee2546e289786142. _name_words uses lower() to match the BM25 tokenizer. The exact-name casefold comparison is unchanged. test_tool_search_transform.py: 120 passed. pre-commit (including mypy) passes on the changed files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
