codeant-ai-for-open-source[bot] commented on code in PR #45151:
URL: https://github.com/apache/superset/pull/45151#discussion_r4233545823
##########
superset-frontend/src/features/roles/utils.ts:
##########
@@ -153,21 +168,10 @@ export const fetchPermissionOptions = async (
const cacheKey = filterValue.trim().toLowerCase();
let cached = permissionSearchCache.get(cacheKey);
if (!cached) {
- const [byViewMenu, byPermission] = await Promise.all([
- fetchAllPermissionPages([
- { col: 'view_menu.name', opr: 'ct', value: filterValue },
- ]),
- fetchAllPermissionPages([
- { col: 'permission.name', opr: 'ct', value: filterValue },
- ]),
- ]);
-
- const seen = new Set<number>();
- cached = [...byViewMenu, ...byPermission].filter(item => {
- if (seen.has(item.value)) return false;
- seen.add(item.value);
- return true;
- });
+ const catalog = await fetchPermissionCatalog();
+ cached = catalog.filter(({ label }) =>
+ label.toLowerCase().includes(cacheKey),
+ );
Review Comment:
**Suggestion:** `cacheKey` keeps underscores, but permission labels replace
them with spaces; searches using raw names such as `can_export_data` therefore
return no option.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Logic error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=a6f8f121bb9140fbbf1482da77002f37&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=a6f8f121bb9140fbbf1482da77002f37&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/features/roles/utils.ts
**Line:** 172:174
**Comment:**
*Logic Error: `cacheKey` keeps underscores, but permission labels
replace them with spaces; searches using raw names such as `can_export_data`
therefore return no option.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45151&comment_hash=b8d5149120976aff86847ffa6023dc4be8b44b784ecb289b38beab2205046d9d&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45151&comment_hash=b8d5149120976aff86847ffa6023dc4be8b44b784ecb289b38beab2205046d9d&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
