codeant-ai-for-open-source[bot] commented on code in PR #45167:
URL: https://github.com/apache/superset/pull/45167#discussion_r4237307144
##########
.github/workflows/github-action-validator.yml:
##########
@@ -31,22 +31,17 @@ jobs:
with:
persist-credentials: false
- - name: Set up Node.js
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 #
v7.0.0
- with:
- node-version-file: "./superset-frontend/.nvmrc"
+ - name: Test docs-deploy freshness gate
+ run: bash .github/workflows/scripts/check-docs-deploy-freshness.test.sh
- - name: Install Dependencies
- # Versions are pinned to avoid ad-hoc, unpinned package installs.
- # Bump deliberately when upgrading.
- # zizmor: ignore[adhoc-packages] - @action-validator is a global CLI
tool installed to validate the repo's workflows; a global CLI install has no
application manifest/lockfile context, and the versions are pinned above
- run: npm install -g @action-validator/[email protected]
@action-validator/[email protected]
+ - name: Setup Go
+ uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e #
v7.0.0
Review Comment:
**Suggestion:** No `go-version` or `go-version-file` is supplied, so
`setup-go` fails before the install step and this validation job never runs.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Often` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=39c033e0ee814f558fa694fcdb6cc277&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=39c033e0ee814f558fa694fcdb6cc277&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** .github/workflows/github-action-validator.yml
**Line:** 37:38
**Comment:**
*Api Mismatch: No `go-version` or `go-version-file` is supplied, so
`setup-go` fails before the install step and this validation job never runs.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45167&comment_hash=aa11037fb6a272d4504fceb92230c147311792cf488a64c079cfe159f2c948b1&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45167&comment_hash=aa11037fb6a272d4504fceb92230c147311792cf488a64c079cfe159f2c948b1&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
