sadpandajoe opened a new pull request, #45171:
URL: https://github.com/apache/superset/pull/45171
### SUMMARY
test_get_entry_shared_lock, added in #45102, passes `key_value_entry.uuid`
(typed `UUID | None` on the `KeyValue` model) directly to
`KeyValueDAO.get_entry`, whose `key` parameter is typed `int | UUID` (no
`None`) — mypy flags this under a full-repo run (`pre-commit run mypy
--all-files`), since `follow_imports = "skip"` for `superset_core.*` otherwise
hides the import on the changed-files-only hook. Adds the same `assert
key_value_entry.uuid is not None` narrowing already used three tests earlier in
`test_get_uuid_entry`.
### TESTING INSTRUCTIONS
Run `pytest tests/unit_tests/dao/key_value_test.py -q` — all tests pass. To
see the mypy failure this fixes, run `pre-commit run mypy --all-files` (or
`mypy` with both `tests/unit_tests/dao/key_value_test.py` and the
`superset-core` package passed on the command line) on master before this
change; the error disappears after.
### ADDITIONAL INFORMATION
- [x] Has associated issue: Fixes #45170
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
