codeant-ai-for-open-source[bot] commented on code in PR #45180:
URL: https://github.com/apache/superset/pull/45180#discussion_r4239481037
##########
superset/db_engine_specs/duckdb.py:
##########
@@ -327,6 +327,18 @@ def convert_dttm(
return f"""'{dttm.isoformat(sep=" ", timespec="microseconds")}'"""
return None
+ @classmethod
+ def register_engine_events(cls, engine: sa.Engine) -> None:
+ # duckdb-engine subclasses the psycopg2 PostgreSQL dialect, whose
+ # class-level _backslash_escapes default is True. Unlike PostgreSQL,
+ # DuckDB never runs the _set_backslash_escapes probe (there is no
+ # standard_conforming_strings knob), so every literal compiled with
+ # literal_binds doubles its backslashes: a filter value like
+ # name\email is rendered as 'name\\email', which DuckDB reads as a
+ # literal double backslash and the query silently matches zero rows.
+ # DuckDB has no escape character at all, so the flag is simply wrong.
+ engine.dialect._backslash_escapes = False
Review Comment:
**Suggestion:** This only changes the created engine; Jinja’s `where_in` and
`escaped_val` compilers use `Database.get_dialect()` with
`_backslash_escapes=True`, so DuckDB filters still double backslashes and miss
matches.
**Assessment:** 🟠 `Major` · 🔁 `Occurrence: Sometimes` · 🏷️ `Incomplete
implementation`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=589d476ba3374b7ea996add2c5923419&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=589d476ba3374b7ea996add2c5923419&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/db_engine_specs/duckdb.py
**Line:** 340:340
**Comment:**
*Incomplete Implementation: This only changes the created engine;
Jinja’s `where_in` and `escaped_val` compilers use `Database.get_dialect()`
with `_backslash_escapes=True`, so DuckDB filters still double backslashes and
miss matches.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45180&comment_hash=5431fdead8c4e73de25f64ba5eeb3dfeaecb7b544ab8da0da5be517f2a293a00&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45180&comment_hash=5431fdead8c4e73de25f64ba5eeb3dfeaecb7b544ab8da0da5be517f2a293a00&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
