codeant-ai-for-open-source[bot] commented on code in PR #45172:
URL: https://github.com/apache/superset/pull/45172#discussion_r4238286197
##########
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts:
##########
@@ -1466,6 +1466,36 @@ test('moves a visible horizontal Plain legend into a
custom HTML legend and rest
expect('contentHeight' in transformed).toBe(false);
});
+test('hides legend selector buttons when showSelectorLegend is false', () => {
+ const plain = transformProps(
+ createTestChartProps({
+ formData: {
+ ...formData,
+ legendOrientation: LegendOrientation.Top,
+ legendType: LegendType.Plain,
+ showLegend: true,
+ showSelectorLegend: false,
+ },
+ }),
+ );
+ expect(getCustomLegend(plain)?.showSelectors).toBe(false);
+
+ const scroll = transformProps(
+ createTestChartProps({
+ formData: {
+ ...formData,
+ legendOrientation: LegendOrientation.Top,
+ legendType: LegendType.Scroll,
+ showLegend: true,
+ showSelectorLegend: false,
+ },
+ }),
+ );
+ expect((scroll.echartOptions.legend as { selector?: unknown
}).selector).toBe(
+ false,
+ );
Review Comment:
**Suggestion:** With `showSelectorLegend: false`, `getLegendProps` still
returns the All/Invert selector array, so this assertion fails and the new test
suite is red.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=1ab863644dce4a758ba883e0bc7b0445&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=1ab863644dce4a758ba883e0bc7b0445&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts
**Line:** 1494:1496
**Comment:**
*Api Mismatch: With `showSelectorLegend: false`, `getLegendProps` still
returns the All/Invert selector array, so this assertion fails and the new test
suite is red.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45172&comment_hash=ecabf2675dda829e3a8f2f7598fbbee4de1be672c06f78bb2e3d8f35c5c62720&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45172&comment_hash=ecabf2675dda829e3a8f2f7598fbbee4de1be672c06f78bb2e3d8f35c5c62720&reaction=dislike'>๐</a>
##########
superset-frontend/plugins/plugin-chart-echarts/test/utils/series.test.ts:
##########
@@ -1257,6 +1277,18 @@ describe('getLegendProps', () => {
...expectedThemeProps,
});
});
+
+ test('hides All and Inv buttons when showSelectorLegend is false', () => {
+ expect(
+ getLegendProps(
+ LegendType.Plain,
+ LegendOrientation.Top,
+ true,
+ theme,
+ false,
+ ).selector,
+ ).toBe(false);
Review Comment:
**Suggestion:** With `showSelectorLegend` false, `getLegendProps` still
returns the selector array, so this assertion fails whenever the test runs.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Often` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=56ad9a651f2646a09f5d8ddc23f4438b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=56ad9a651f2646a09f5d8ddc23f4438b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/test/utils/series.test.ts
**Line:** 1282:1290
**Comment:**
*Api Mismatch: With `showSelectorLegend` false, `getLegendProps` still
returns the selector array, so this assertion fails whenever the test runs.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45172&comment_hash=975986d4871b9b3de1ea599d3944e737ec8eb1ff092c604e2f378698a9b284ca&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45172&comment_hash=975986d4871b9b3de1ea599d3944e737ec8eb1ff092c604e2f378698a9b284ca&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
