sadpandajoe commented on code in PR #45183: URL: https://github.com/apache/superset/pull/45183#discussion_r4241699787
########## .devcontainer/Dockerfile: ########## @@ -1,5 +1,5 @@ # Keep this in sync with the base image in the main Dockerfile (ARG PY_VER) -FROM python:3.11-trixie AS base +FROM python:3.12-trixie AS base Review Comment: `.devcontainer/devcontainer-base.json` still pins `python:3.11-bookworm`, and the default and with-mcp devcontainers use it, so Codespaces on those configs stay on 3.11 while this Dockerfile moves to 3.12 despite the keep-in-sync note. Should that image be bumped to `python:3.12-bookworm` in this PR too? ########## Dockerfile: ########## @@ -18,7 +18,7 @@ ###################################################################### # Node stage to deal with static asset construction ###################################################################### -ARG PY_VER=3.11-slim-trixie +ARG PY_VER=3.12-slim-trixie Review Comment: Moving the default image to 3.12 while `current` still resolves to 3.11 means the unit and PR integration jobs never run on the interpreter the image ships, and 3.13 would leave the same gap since only the nightly canary runs `next`. Could `current` in `.github/actions/setup-backend/action.yml` move to 3.12 in this PR, or can you point to a job that runs the backend suite on 3.12? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
