rusackas commented on issue #38453:
URL: https://github.com/apache/superset/issues/38453#issuecomment-6111753835
@kokhlo nice, that diagnosis holds up. I traced it on the pinned versions
too: duckdb-engine's `initialize` goes straight to `DefaultDialect.initialize`,
so the `_set_backslash_escapes` probe never runs and the psycopg2 default
sticks. It's the same flag Mause/duckdb_engine#1401 flips, and nothing has
shipped there since 0.17.0, so carrying the fix in the spec via
`register_engine_events` seems like the right shape to me.
One gap though: the Jinja path isn't covered yet. `where_in` and
`escaped_val` build a fresh dialect from `Database.get_dialect()`, which never
sees the hook, and `_normalize_postgresql_backslash_escapes` only fires when
`dialect.name == "postgresql"`. So `{{ filter_values('columnA') | where_in }}`
on DuckDB still renders `'name\\email'`. Worth folding that into #45180
(widening the helper to duckdb, or keying both paths off the spec) rather than
leaving the Jinja side open?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
