rusackas commented on code in PR #44817:
URL: https://github.com/apache/superset/pull/44817#discussion_r4243282017
##########
.pre-commit-config.yaml:
##########
@@ -46,6 +49,38 @@ repos:
name: mypy (superset-extensions-cli)
args: [--check-untyped-defs]
files: ^superset-extensions-cli/
+ - id: mypy
+ alias: mypy-sole-input-fixtures
+ name: mypy (sole-input fixtures)
+ # Regression guards that only mean something when mypy checks the
+ # fixture as its ONLY input: a type that resolves one way with the
+ # whole tree loaded and another way in a scoped per-PR run (e.g.
+ # UUIDMixin.uuid, see tests/mypy_fixtures/uuid_mixin_nullable.py).
+ # Manual stage, so neither a local `pre-commit run --all-files` nor
+ # the per-PR / nightly runs of the main hook pick it up; CI invokes
+ # it explicitly, one fixture at a time, in
+ # .github/workflows/pre-commit.yml. --no-incremental keeps it from
+ # reusing full-tree types the main hook may already have cached.
+ args: [--check-untyped-defs, --no-incremental]
Review Comment:
Good call @sadpandajoe. Added `--follow-imports=silent` to the sole-input
hook so only the fixture itself reports errors, and rebased onto master. CI
will show whether it comes back green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
