rusackas commented on PR #38094: URL: https://github.com/apache/superset/pull/38094#issuecomment-6114117643
Thanks for the rebase @lucapazz, this is looking close. The one thing I'd still like to see is the end-to-end test @EnxDev asked for: a `TimeTable.test.tsx` case that clicks a time column header and a sparkline header and checks the row order. Right now `sortUtils.test.ts` hand-builds `cellValues`, so it wouldn't catch the wiring in `TimeTable.tsx` breaking. Also, could you take a look at the sparkline null-gap thread from codeant? Not sure if the linear scale still turns those nulls into zeros. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
