codeant-ai-for-open-source[bot] commented on code in PR #45204:
URL: https://github.com/apache/superset/pull/45204#discussion_r4243424158
##########
superset-frontend/packages/superset-ui-core/src/connection/SupersetClientClass.ts:
##########
@@ -149,15 +149,27 @@ export default class SupersetClientClass {
return this.fetchCSRFToken();
}
+ /**
+ * Submit a hidden form via POST.
+ * @param endpointOrConfig - an endpoint (resolved against the app root), or
+ * an object with either an `endpoint` or an already absolute `url`, which
+ * is used as is.
+ * @param payload - form fields
+ * @param target - form target, defaults to a new tab
+ */
async postForm(
- endpoint: string,
+ endpointOrConfig: string | { endpoint?: string; url?: string },
payload: Record<string, any>,
target = '_blank',
) {
- if (endpoint) {
+ const { endpoint, url } =
+ typeof endpointOrConfig === 'string'
+ ? { endpoint: endpointOrConfig, url: undefined }
+ : endpointOrConfig;
+ if (endpoint || url) {
await this.ensureAuth();
const hiddenForm = document.createElement('form');
- hiddenForm.action = sanitizeUrl(this.getUrl({ endpoint }));
+ hiddenForm.action = sanitizeUrl(this.getUrl({ endpoint, url }));
Review Comment:
**Suggestion:** `url` can point to another origin, so this form sends the
client’s CSRF token and guest token there whenever a caller supplies an
external URL.
**Assessment:** 🟠 `Major` · 🔁 `Occurrence: Rarely` · 🏷️ `Security`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=46f31acb293b4a2b90483cf85377f66a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=46f31acb293b4a2b90483cf85377f66a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/packages/superset-ui-core/src/connection/SupersetClientClass.ts
**Line:** 172:172
**Comment:**
*Security: `url` can point to another origin, so this form sends the
client’s CSRF token and guest token there whenever a caller supplies an
external URL.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45204&comment_hash=8508d4af00fc50ccaea6320cc94d6470faa7c351336a1370dfaf724a92e9504b&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45204&comment_hash=8508d4af00fc50ccaea6320cc94d6470faa7c351336a1370dfaf724a92e9504b&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
