FrancescoCastaldi commented on PR #44894: URL: https://github.com/apache/superset/pull/44894#issuecomment-6114720988
Hi @rusackas @sadpandajoe, Pushed commits `e7c9b0e0de` and `7019744718` addressing review findings: 1. Option groups traversal: Updated `getOption` in `Select/utils.tsx` to recursively inspect child `options` arrays when grouped option items are encountered (`isObject(x) && Array.isArray(x.options)`). This ensures matching child options within option groups are detected and optimistic duplicates are dropped properly. 2. Unified new-option filter helper: Extracted the shared `isRedundantNewOption` predicate in `AsyncSelect.tsx`, consolidating the duplicate detection across `mergeData` and the initial page search response filter. All TypeScript checks and unit tests pass cleanly. Whenever you have a moment, please take a look. @coderabbitai review @bito-code-review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
