aminghadersohi commented on code in PR #44657:
URL: https://github.com/apache/superset/pull/44657#discussion_r4243718852
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/utilities.ts:
##########
@@ -480,12 +553,36 @@ const baseAggregatorTemplates = {
return function () {
return {
sum: 0 as any,
+ // Tracks whether every pushed value was a SQL NULL, so a fraction
+ // aggregator can keep an all-null scope blank instead of 0.
Review Comment:
Still open at 482f2e1: `aggregateFunction: 'Sum'` wraps `tpl.sum`, whose
`value()` returns 0 for an all-NULL scope, so it renders `0.00`, not blank as
the Average NULL thread assumes. The same null-for-empty-scope fix covers both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
