villebro opened a new pull request, #429:
URL: https://github.com/apache/superset-kubernetes-operator/pull/429
## Summary
The basic sample (`config/samples/superset_v1alpha1_superset.yaml`) cannot
run against the dev backing services in `config/samples/dev-dependencies.yaml`.
It uses the lean `6.1.0` image, which ships no database drivers, so the migrate
task fails with `ModuleNotFoundError: No module named 'psycopg2'`. It also sets
no Valkey password, while the dev Valkey requires `superset`. Separately, the
development setup guide hand-builds a third Postgres/Valkey variant
(passwordless Valkey, `postgres:16`). This PR makes `dev-dependencies.yaml` the
single source of truth for local dev and adds a unit test so the samples cannot
drift from it again.
## Details
- **Basic sample:** `image.tag: 6.1.0-dev` (includes `psycopg2`) and
`valkey.password: superset`. The header now points at `dev-dependencies.yaml`
and explains why the `-dev` variant is needed.
- **`dev-dependencies.yaml`:** the header now says it backs both
Development-mode samples.
- **`docs/contributing/development-setup.md`:** steps 2–3 are replaced by
`kubectl apply -f config/samples/dev-dependencies.yaml`, and the following
steps are renumbered. No docs link to these anchors.
- **`test/samples/samples_test.go`** (runs under `make test-unit`):
- Finds every `superset_v1alpha1_*.yaml` sample with `environment:
Development`.
- Identifies the PostgreSQL and Valkey Deployments in
`dev-dependencies.yaml` from their configuration, and resolves each host from
the Service that selects it.
- Asserts each sample's metastore (URI or structured fields) and Valkey
host, port, credentials and database match, and that the image tag is a `-dev`
variant.
- Against the current `main` sample it fails on both the lean image tag
and the missing Valkey password.
Verified on Kind 0.33 (`kindest/node:v1.37.0`) with the operator built from
`main` @ 27da539: `dev-dependencies.yaml` plus the updated basic sample reach
`Running` / `Available` in about 4 minutes. `/health` returns `OK` and
`/login/` returns 200. `make lint-go` and `make lint-md` pass.
Not changed here: the README, `docs/getting-started.md`, `docs/index.md` and
some user-guide snippets also pair the lean `6.1.0` image with a
`postgresql+psycopg2` URI. `configuration.md` already documents that lean
images ship without drivers, so I've left those for a separate discussion. The
`0.3` branch has the same basic sample, if a backport is wanted.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
