younsl commented on code in PR #426:
URL:
https://github.com/apache/superset-kubernetes-operator/pull/426#discussion_r4250317836
##########
charts/superset-operator/values.schema.json:
##########
@@ -52,6 +52,20 @@
"required": ["resourceName", "restartPolicy"]
}
},
+ "extraEnv": {
+ "description": "Extra environment variables for the manager container.
WATCH_NAMESPACE is reserved for the watch block. See
https://pkg.go.dev/k8s.io/api/core/v1#EnvVar";,
+ "type": "array",
+ "items": {
+ "type": "object",
+ "additionalProperties": false,
+ "properties": {
+ "name": { "type": "string", "minLength": 1, "not": { "const":
"WATCH_NAMESPACE" } },
Review Comment:
Done in d31c6bc. The schema now only requires a non-empty name, and the
template fails with "extraEnv must not set WATCH_NAMESPACE; configure
watch.scope and watch.namespaces instead" right after the
replicas/leaderElection check. The test moved next to the replicas test in
optout_and_helpers_test.yaml and asserts the message with errorMessage, and
schema_strictness_test.yaml is back to its main version.
##########
charts/superset-operator/values.yaml:
##########
@@ -30,6 +30,11 @@ resources:
# See
[corev1.ContainerResizePolicy](https://pkg.go.dev/k8s.io/api/core/v1#ContainerResizePolicy).
resizePolicy: []
+# -- Extra environment variables for the manager container, such as proxy
settings or `GOMEMLIMIT`.
Review Comment:
Good point about client-go honouring HTTPS_PROXY, thanks. Applied your
suggested description in d31c6bc and regenerated the README with make codegen.
I also swapped the HTTPS_PROXY entry in the full-options test values for
GODEBUG so nothing in the chart points at a proxy.
##########
docs/reference/releases.md:
##########
@@ -27,6 +27,7 @@ This page tracks notable changes in Apache Superset
Kubernetes Operator releases
- **Helm `dnsPolicy` and `dnsConfig`.** The Helm chart now exposes `dnsPolicy`
and `dnsConfig` values for the operator manager pod
([#394](https://github.com/apache/superset-kubernetes-operator/pull/394),
[@younsl](https://github.com/younsl)).
- **Helm `priorityClassName`.** The Helm chart now exposes a
[`priorityClassName`](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/)
value that sets the PriorityClass of the operator manager pods. Unset by
default, which keeps the cluster default priority
([#420](https://github.com/apache/superset-kubernetes-operator/pull/420),
[@younsl](https://github.com/younsl)).
+- **Helm `extraEnv`.** The Helm chart now exposes an `extraEnv` value that
appends environment variables to the operator manager container, for example
proxy settings or a `GOMEMLIMIT` derived from the memory limit.
`WATCH_NAMESPACE` is rejected by the values schema because the `watch` block
owns it
([#426](https://github.com/apache/superset-kubernetes-operator/pull/426),
[@younsl](https://github.com/younsl)).
Review Comment:
Applied as suggested in d31c6bc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
