SBIN2010 opened a new pull request, #45223: URL: https://github.com/apache/superset/pull/45223
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The ECharts bubble chart now supports dashboard cross-filtering, as well as drill-to-detail and drill-by functionality. This addresses the issue described in discussion https://github.com/apache/superset/discussions/31728: previously, clicking a bubble did not filter other charts sharing the same dataset. Clicking a bubble filters other charts based on the corresponding entity and, if a series dimension is defined, the series. Clicking the same bubble again clears the filter. Bubbles that do not match the active selection become semi-transparent, and the cursor changes to a pointer only when cross-filtering is enabled for the chart. A missing measurement value is passed as `IS NULL`. An empty string remains an `IN` filter value of `''` and is displayed as `""`, ensuring that the filter chip, legend, and tooltip do not conflate it with `<NULL>`. The filter chip displays a clear label (`entity` or `entity, series`). Selected values are stored in the dashboard state as a JSON array, so `null`, `''`, and numeric values remain distinguishable, and the key is preserved correctly when using permalinks. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Create a Bubble chart with Entity, X, Y, and Size, and optionally a Series dimension. Add it to a dashboard that has cross-filtering enabled, next to another chart on the same dataset (the setup from https://github.com/apache/superset/discussions/31728). 2. Click a bubble. The other chart should filter to that entity (and series, when set), the filter chip should show the readable label, and the other bubbles should dim. 3. Click the same bubble again. The filter and the dimming should clear. 4. Repeat with a null entity and a null series. The emitted filter should use `IS NULL`, and the chip should show `<NULL>`. 5. Right-click a bubble. The context menu should offer cross-filter, drill to detail, and drill by, including `IS NULL` for an empty dimension. 6. Turn cross-filtering off for the dashboard (or chart). Clicks should no longer emit a filter, and the cursor should stay the default. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/discussions/31728 - [ ] Required feature flags: - [x ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
