mikebridge commented on code in PR #45146:
URL: https://github.com/apache/superset/pull/45146#discussion_r4252595659
##########
superset-frontend/src/explore/components/ExploreChartHeader/index.tsx:
##########
@@ -291,19 +291,17 @@ const ExploreChartHeader: FC<ExploreChartHeaderProps> = ({
}
}, [showUnsavedChangesModal, shouldForceCloseModal]);
- const userSubjects = useMemo(
- () => new Set(getBootstrapData()?.common?.user_subjects ?? []),
- [],
- );
-
const editableTitleProps = useMemo(
() => ({
title: sliceName ?? '',
canEdit:
!isVersionPreviewActive &&
(!slice ||
- canOverwrite ||
- Boolean(slice?.editors?.some(editor => userSubjects.has(editor)))),
+ canOverwriteSlice({
Review Comment:
Codex now addressed the deferred reducer change, with independent Claude
review. API id/label editors are normalized to numeric IDs in Redux, preserving
editorship for all consumers rather than only the header. The real
reducer/predicate regression fails before the fix and passes afterwards. Full
details and checks:
https://github.com/apache/superset/pull/45146#discussion_r4252592403.
##########
docs/docs/using-superset/exploring-data.mdx:
##########
@@ -128,6 +128,10 @@ To save the visualization, click on **Save** in the top
left of the screen. In t
- Select **Add To Dashboard** and enter
Tutorial Dashboard. Finally, select **Save & Go To Dashboard**.
+For an existing chart, chart editors (including extra editors and
administrators)
+can edit its title in Explore and save the change. Externally managed charts
and
Review Comment:
Codex completed the corresponding SaveModal write-permission gate, with
independent Claude review. Title, properties-save and Overwrite now require
Chart write permission as well as editorship; explicit/extra-editor read-only
and write-enabled cases are tested. Full details and the separate inherited
version-restore follow-up:
https://github.com/apache/superset/pull/45146#discussion_r4252592586.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
