fitzee opened a new pull request, #45233: URL: https://github.com/apache/superset/pull/45233
## TL;DR Horizon charts with metrics and no group-by return string series keys. Rendering called `.join()` on those strings and failed. Normalize keys with the same helper already used for row titles, and accept both key shapes in the component type. ### SUMMARY The legacy-query migration produces `LegacySeries.key` as `string | string[]`. Grouped charts worked, but an ungrouped metric such as `revenue` caused `TypeError: row.key.join is not a function`. The component now handles both forms. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: an ungrouped metric raises the exception above instead of rendering. After: the metric renders one Horizon row titled `revenue`; grouped row labels are unchanged. ### TESTING INSTRUCTIONS - Create a Horizon chart with a time column and a metric, leaving group-by empty. Confirm that it renders. - Add group-by columns and confirm the joined labels still render. - Component tests: 4 passed, including the ungrouped regression case. - Frontend `npm run lint`: passed. - Pre-commit formatting, lint and custom/style rules passed. The targeted type-check hook could not complete because this local worktree lacks built project-reference declarations (`TS6305`); a dependency declaration build also encounters `TS2742` from the shared local node_modules path. A clean CI type check remains required. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
