sadpandajoe commented on code in PR #45198:
URL: https://github.com/apache/superset/pull/45198#discussion_r4254495590
##########
superset-frontend/plugins/plugin-chart-country-map/package.json:
##########
@@ -26,7 +26,7 @@
"access": "public"
},
"dependencies": {
- "d3": "^3.5.17",
+ "d3": "^7.9.0",
Review Comment:
Even once the v3 API calls are migrated, Jest still can't load the
plugin-local d3 7.9.0: its entry is ESM (`node_modules/d3/src/index.js`), and
`transformIgnorePatterns` in `jest.config.js` only lets
`d3-(array|interpolate|color|time|scale|time-format|format|selection)` through
Babel, not `d3`, `d3-dispatch` or `d3-transition`. That is what the failing
`sharded-jest-tests` shards 1, 7 and 8 show: `SyntaxError: Unexpected token
'export'` at the country-map and world-map `d3/src/index.js:1`, before any
assertion runs. Should the Jest transform allowlist be extended for the d3 7
dependency graph as part of this bump?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
