EnxDev commented on PR #45234:
URL: https://github.com/apache/superset/pull/45234#issuecomment-6139913793

   Before/after recordings. Same build both times, with and without this 
change. The dashboard has a table and an ECharts pie with a 10 second refresh 
interval, and the `/api/v1/chart/data` requests are delayed by 5 seconds so the 
in-flight window is easy to see.
   
   **Before (master):** each chart turns into the no-results state while its 
refresh request is in flight.
   
   
![before](https://raw.githubusercontent.com/EnxDev/superset/7469e31ed152ba7374035acd0651d3584b643821/before.gif)
   
   **After (this PR):** both charts stay on screen through the refresh.
   
   
![after](https://raw.githubusercontent.com/EnxDev/superset/7469e31ed152ba7374035acd0651d3584b643821/after.gif)
   
   This replaces the note in the description that the "after" hadn't been run 
in a browser. MP4 versions: 
[before](https://raw.githubusercontent.com/EnxDev/superset/7469e31ed152ba7374035acd0651d3584b643821/before.mp4),
 
[after](https://raw.githubusercontent.com/EnxDev/superset/7469e31ed152ba7374035acd0651d3584b643821/after.mp4).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to